Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: implement conversion helpers #1227

Merged
merged 2 commits into from
Jul 27, 2020
Merged

cli: implement conversion helpers #1227

merged 2 commits into from
Jul 27, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jul 23, 2020

Support everything from neo-project/neo-node#535 . Checked examples from there.
Also support swapping endianness for arbitrary hex strings.

Close #1207 .

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #1227 into master will increase coverage by 4.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
+ Coverage   62.64%   66.66%   +4.01%     
==========================================
  Files         200      199       -1     
  Lines       17123    17037      -86     
==========================================
+ Hits        10726    11357     +631     
+ Misses       5810     5065     -745     
- Partials      587      615      +28     
Impacted Files Coverage Δ
pkg/vm/cli/cli.go 0.00% <0.00%> (ø)
pkg/core/interop/crypto/ecdsa.go 74.46% <0.00%> (-12.77%) ⬇️
pkg/vm/stackitem/item.go 90.04% <0.00%> (-0.44%) ⬇️
pkg/crypto/keys/private_key.go 84.33% <0.00%> (-0.37%) ⬇️
pkg/core/native/policy.go 70.58% <0.00%> (-0.35%) ⬇️
pkg/vm/slot.go 100.00% <0.00%> (ø)
pkg/vm/exception.go
pkg/vm/opcode/opcode_string.go 2.13% <0.00%> (+0.05%) ⬆️
pkg/vm/vm.go 88.95% <0.00%> (+0.39%) ⬆️
pkg/core/blockchain.go 69.40% <0.00%> (+0.78%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c823d...5fe8095. Read the comment docs.

@roman-khimov
Copy link
Member

It needs to be rebased.

Implement parse command for converting arbitrary values to other
formats. It supports Integer, String, Hex, Base64 and
Address representations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Completely new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI conversion helpers
3 participants